ParamQuery grid support forum

General Category => Bug Report => Topic started by: Ron Hess on December 09, 2013, 11:40:39 pm

Title: pageModel.totalPages -> should be ? ---> dataModel.totalPages
Post by: Ron Hess on December 09, 2013, 11:40:39 pm

Total pages was found in dataModel not pageModel

Docs:
var totalPages=$( ".selector" ).pqGrid( "option", "pageModel.totalPages" );


i had to change this to
var totalPages=$( ".selector" ).pqGrid( "option", "dataModel.totalPages" );


to get it to work on 2.0.2

does this change in 2.0.3?  or is the doc incorrect ?

Title: Re: pageModel.totalPages -> should be ? ---> dataModel.totalPages
Post by: paramvir on December 10, 2013, 12:49:17 am

Ron

Sorry for the confusion. I would update the API docs to clarify this.

pageModel is introduced in version 2.0.3

http://paramquery.com/forum/index.php?topic=395.0

Title: Re: pageModel.totalPages -> should be ? ---> dataModel.totalPages
Post by: Ron Hess on December 21, 2013, 11:15:48 pm

I guess my feedback is :

please don't change the API within a minor number revision, this should be reserved for bug fixes.

new or changed API should obvious, 2.1.0  or 2.X.0,  so that i know to read the docs before upgrading.

Thanks for the upgrade docs, the actual API Docs should list the version that each feature is introduced in.

Title: Re: pageModel.totalPages -> should be ? ---> dataModel.totalPages
Post by: paramvir on December 22, 2013, 12:53:13 pm

Ron

Thanks for your feedback.

Your suggestions would be duly taken care of as far as possible.

Probably introduction of new features the kind of which necessitate breaking changes need to wait until major version release 2.X.0

All the inter version migration steps have been updated here http://paramquery.com/pro/tutorial#topic-migration