Author Topic: Please change one line of code in next version  (Read 256 times)

jplevene

  • Pro Ultimate
  • Full Member
  • *
  • Posts: 126
    • View Profile
Please change one line of code in next version
« on: August 15, 2024, 12:55:33 am »
I think it is line 4490 from (inside fn.remoteRequest):

Code: [Select]
if (that.loading) {
to

Code: [Select]
if (that.loading && that.xhr && typeof(that.xhr)==="function") {
When I re-open a jquery UI dialog that contains a pqGrid and load it with new data I get the attached error.  The above code prevents that.

Also another different issue is to do with jQuery UI.  If the grid is in a MODAL jquery UI dialog and a grid filter shows a popup grid for filter options, if that popup has an input filter, it won't work and you can't type anything into it.  This is due to the jQuery UI screen mask that disables all keyboard and mouse events from going through it.  As the popup is attached to the body which is below the mask (z-index doesn't count), it doesn't get the keyboard events as they are stopped by the mask.  To overcome this I suggest making popup's parent the grid element (which is above the mask) and not the document body.

If you reply with jsFiddle template I'll build all the examples for you.
« Last Edit: August 15, 2024, 01:47:33 am by jplevene »

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6298
    • View Profile
Re: Please change one line of code in next version
« Reply #1 on: August 15, 2024, 01:26:21 pm »

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6298
    • View Profile
Re: Please change one line of code in next version
« Reply #2 on: August 18, 2024, 11:38:39 am »
Please include all reported bugs with relevant test cases or steps to reproduce the issue.

You have reported 2 issues in this post.

Second issue  ( key input in grid filter in jQueryUI modal popup ) is understandable but 1st issue needs some test case.
« Last Edit: August 18, 2024, 03:33:16 pm by paramvir »

jplevene

  • Pro Ultimate
  • Full Member
  • *
  • Posts: 126
    • View Profile
Re: Please change one line of code in next version
« Reply #3 on: October 07, 2024, 04:12:28 pm »
This was weeks ago.  I did a fix and will have to see what I did.

jplevene

  • Pro Ultimate
  • Full Member
  • *
  • Posts: 126
    • View Profile
Re: Please change one line of code in next version
« Reply #4 on: October 29, 2024, 06:44:41 am »
Found the bug.  It is caused by calling "showLoading" before loading remote data.

The issue is that this.loading is true, but at this point there is no XHR, thus the bug and the reason the fix works.

jplevene

  • Pro Ultimate
  • Full Member
  • *
  • Posts: 126
    • View Profile
Re: Please change one line of code in next version
« Reply #5 on: October 29, 2024, 11:01:03 pm »
If you need the code:

Code: [Select]
$("#grid").pqGrid("showLoading").pqGrid("refreshDataAndView");

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6298
    • View Profile
Re: Please change one line of code in next version
« Reply #6 on: October 30, 2024, 01:07:15 pm »
Noted, thanks.