Author Topic: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3  (Read 3089 times)

ami dev

  • Pro Ultimate
  • Newbie
  • *
  • Posts: 18
    • View Profile
Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« on: October 23, 2018, 02:07:45 pm »
We have been using version 4.0.3 and upgraded to version 5.4.0.
We found a few unexpected behaviors. We would like to know if these behaviors are expected.
If not, do you have a plan to fix these issues?

#1 Localization at pagers is partially incomplete.
When we use pagers for version 4, all the labels are displayed properly in selected language.
However when we use pagers for version 5, some labels remain in English even though we selected different language.
Please see the attached image_1.png that a red square shows labels remaining English and blue one shows localized labels as expected.
It seems localized files other than English are not updated properly in version 5 in the first place.


#2 Heights of rows are not adjusted in refreshRow.
Heights of rows were automatically adjusted when the refreshRow was fired after we modified values in the cell for version 4. (See image_2-1.png,image_2-2.png)


However after upgrading to version 5, the heights of rows were not adjusted when the refreshRow was fired. And the extended labels are hidden. (See image_3.png)

So we had to call refreshView to refresh the whole grid instead in order to adjust the heights.

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6263
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #1 on: October 24, 2018, 08:12:36 am »
These would be addressed in the upcoming versions.

refreshView() is an overkill to adjust the height, refresh() or refresh({header: false}) can be used instead.

ami dev

  • Pro Ultimate
  • Newbie
  • *
  • Posts: 18
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #2 on: October 24, 2018, 08:29:17 am »
Thank you very much for your response.
We will try to use resfresh() instead.

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6263
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #3 on: October 24, 2018, 09:15:48 pm »
In order to correctly apply localization in pager, please add these lines before initialization of grid. These lines can also be added at the bottom of localization file.

Code: [Select]
var pq = $.paramquery     
 $.extend( pq.pqGrid.defaults, pq.pqGrid.regional.ja );
 $.extend( pq.pqPager.defaults, pq.pqPager.regional.ja );

https://plnkr.co/edit/wIxUSZ0gtFn5f5bLpVmd?p=preview

ami dev

  • Pro Ultimate
  • Newbie
  • *
  • Posts: 18
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #4 on: October 25, 2018, 06:51:58 am »
Thank you very much. It worked in pager!
Would the localization of filters be addressed in the upcoming versions?
« Last Edit: October 25, 2018, 07:10:05 am by ami dev »

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6263
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #5 on: October 25, 2018, 11:17:10 am »
Yes those would be addressed.

ami dev

  • Pro Ultimate
  • Newbie
  • *
  • Posts: 18
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #6 on: November 28, 2018, 07:43:14 am »
We updated to v5.6 but the grid doesn't work correctly.
The following error will occur on the line 3 in pq-localize-pt-br.js when it's initialized.
Code: [Select]
    pq.pqGrid.regional.pt-br = {
It seems like syntax error occurs because we cannot use hyphen(-) in variable names.
Can you take a look into this? Would it be addressed shortly?

paramvir

  • Administrator
  • Hero Member
  • *****
  • Posts: 6263
    • View Profile
Re: Unexpected behaviors when upgrading to v5.4.0 from v4.0.3
« Reply #7 on: November 28, 2018, 11:03:05 am »
I understand that's a problem with single localization file pt-br.

Please replace all occurences of regional.pt-br with regional['pt-br'] in the file for now.
« Last Edit: November 28, 2018, 11:15:18 am by paramquery »