Bugs in v11

[jplevene]

Code: [Select]

selectionModel: { type:"row", mode:"single", column:false, all:false, toggle:false},

1) A row is selected correctly, however it also selects the cells which it didn't do before in v10.  Note the type:"row" and both should only happen if type:null
2) "toggle:false" still doesn't work.  I have to do the below patch to prevent toggle off if I click the row twice.  The docs say this isn't a bug, but when I last posted it, you said it was.

Code: [Select]

rowClick: function(event, ui) {
var sel = that.grid.pqGrid("SelectRow");
if( !sel.isSelected({rowIndx:ui.rowIndx }) )
sel.add({rowIndx:ui.rowIndx});
},

[paramvir]

1) I wasn’t able to observe any cell selections in the row selection example:
https://paramquery.com/pro/demos/selection_row

2) The toggle functionality behaves exactly as described in the API documentation:
https://paramquery.com/pro/api#option-selectionModel

Therefore, this appears to be the intended behavior and not a bug.

[jplevene]

1) I'm confused, it is literally there in the demo you linked to (see attached screen shots one with Overcast theme, the other with Office).  The cell should not be selectable as selectionModel.type="row".  Other themes show it, some not as obvious due to the colours used.

2) I understand it is in the docs, but when I reported it originally, as it didn't seem correct you said it would be fixed.  I have posted a workaround, just thought I would mention it as it seems wrong so not to worry as it is not an issue for me.

[paramvir]

I understand the confusion — what you’re seeing in the screenshot isn’t a cell selection, it’s the cell focus indicator.

Even when selectionModel.type = "row", the grid still maintains focus on one cell for keyboard navigation and accessibility purposes (for example, so screen readers and keyboard users know which cell is active).

This focus outline has always been part of the grid’s behavior across all versions — though some themes make it more visually noticeable than others due to color differences.

[jplevene]

The cell selection/focus was not there in v10 as if I run the same code on both, it appears on v11 and not v10

If this is now standard, how do I remove it for a specific grid, not all as some grids we use cell selection?

[jplevene]

I tried the following:

Code: [Select]

focus: function(event, ui) {
$(ui.cell).removeClass("pq-focus");
}
The above sort of worked, except when the row scrolled out and in view, the focus came back, so I added:

Code: [Select]

var focus = that.grid.pqGrid("getFocus");
if(focus && focus.rowData)
that.grid.pqGrid("focus");
The above resulted in bad results, especially when scrolling down and selecting a row.

Lastly, I reported another issue with the grid scrolling to the top when it lost and gets back focus.  As I can see the focus I can see what the issue is:

• Last time you told me to change the CSS to remove the focused cell border, thus the above bug in V10 looked like it worked and I could see the focused cell.
• Now I can see the focused cell, what happens when the grid loses the focus (in essence the cell loses the focus) then when the grid gets it back, instead of selecting the previously focused cell, it selects the first cell in the first row, this is why it scrolls to the top.

I think the solution here is to have an option to disable cell focus, but only if cell editing is disabled obviously.

[paramvir]

cell focus can be prevented on cell click by using new option in v11.1.0

Code: [Select]

focusModel: {
        focusable: false,
    },

Example: https://paramquery.com/pro/demos/selection_row

Please note the cell can still be focused by tab.